Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): timeout in rpc_regression_tests #5153

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jan 17, 2025

Summary of changes

Changes introduced in this pull request:

  • download test snapshots in parallel

Reference issue to close (if applicable)

Closes #5146

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 force-pushed the hm/rpc_regression_tests_timeout branch from 3198b64 to 81bb02f Compare January 17, 2025 11:21
@hanabi1224 hanabi1224 marked this pull request as ready for review January 17, 2025 11:23
@hanabi1224 hanabi1224 requested a review from a team as a code owner January 17, 2025 11:23
@hanabi1224 hanabi1224 requested review from elmattic and sudo-shashank and removed request for a team January 17, 2025 11:23
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanabi1224 I wonder if we could avoid handling this ourselves. Nextest runs tests in parallel, so if we split the tests into smaller ones, e.g., one test per endpoint type, we could get it for free. I imagine this could be done with a limited amount of macros.

Would it be feasible?

@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Jan 17, 2025

@LesnyRumcajs I feel data-driven testing framework in Rust is not yet super mature, https://crates.io/crates/datatest requires nightly features and https://crates.io/crates/datatest-stable requires complicated configurations. How about merging this to unblock CI and tackle data-driven testing later?

@hanabi1224 hanabi1224 enabled auto-merge January 17, 2025 15:19
@hanabi1224 hanabi1224 requested a review from lemmih January 17, 2025 15:22
@hanabi1224 hanabi1224 force-pushed the hm/rpc_regression_tests_timeout branch from 81bb02f to 384ef85 Compare January 20, 2025 08:58
@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 3bae32a Jan 20, 2025
34 of 35 checks passed
@hanabi1224 hanabi1224 deleted the hm/rpc_regression_tests_timeout branch January 20, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor rpc_regression_tests to download test snapshots in parallel
3 participants