-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update URLs, correct spelling, and improve phrasing #5134
Conversation
Replaced the outdated Twitter URL (https://twitter.com/) with the updated x.com format (https://x.com/) to align with the platform's rebranding.
- Changed "entails upgrading" to "entails upgrading to" - Corrected "failing to follow the chain errors" to "failing to follow chain errors" - Replaced "it may make sense" with "it might make sense" - Fixed "stop your note" to "stop your node"
- Changed "telemetries" to "telemetry" for correct usage - Capitalized "Loki" and "Grafana" to reflect proper nouns - Corrected "docker compose" to "docker-compose"
@@ -6,7 +6,7 @@ We run spellchecks using | |||
It delegates to a program called | |||
[`Hunspell`](https://github.com/hunspell/hunspell). | |||
|
|||
Hunspell accepts uses `dictionary` files for words and `affix` files to define | |||
Hunspell accept use `dictionary` files for words and `affix` files to define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still incorrect phrasing.
@@ -11,7 +11,7 @@ | |||
<a href="https://github.com/ChainSafe/forest/blob/main/LICENSE-APACHE"><img alt="License Apache 2.0" src="https://img.shields.io/badge/License-Apache%202.0-blue.svg?style=for-the-badge"></a> | |||
<a href="https://github.com/ChainSafe/forest/blob/main/LICENSE-MIT"><img alt="License MIT" src="https://img.shields.io/badge/License-MIT-yellow.svg?style=for-the-badge"></a> | |||
<a href="https://discord.gg/Q6A3YA2"><img alt="Discord" src="https://img.shields.io/discord/593655374469660673.svg?style=for-the-badge&label=Discord&logo=discord"></a> | |||
<a href="https://twitter.com/ChainSafeth"><img alt="Twitter" src="https://img.shields.io/twitter/follow/chainsafeth?style=for-the-badge&color=1DA1F2"></a> | |||
<a href="https://x.com/ChainSafeth"><img alt="Twitter" src="https://img.shields.io/x/follow/chainsafeth?style=for-the-badge&color=1DA1F2"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview doesn't work, the link seems broken.
@@ -10,15 +10,15 @@ import TabItem from "@theme/TabItem"; | |||
<TabItem value="binaries" label="Binaries" default> | |||
|
|||
To install Forest from pre-compiled binaries, please refer to the | |||
[releases page](https://github.com/ChainSafe/forest/releases), or consider using | |||
[releases page](https://GitHub.com/ChainSafe/forest/releases), or consider using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no point in doing that in URLs.
@@ -7,24 +7,24 @@ sidebar_position: 2 | |||
|
|||
Network upgrades happen periodically in Filecoin. They bring new features to the network, proposed via [FIPs](https://github.com/filecoin-project/FIPs) and are announced via several channels, including the [filecoin-project/community discussions](https://github.com/filecoin-project/community/discussions) and the Filecoin Slack. Also, all Filecoin implementations make the announcements on their own. In Forest's case, it's on [Forest's Discussions](https://github.com/ChainSafe/forest/discussions) and the `#fil-forest-announcements` channel in the Filecoin Slack. | |||
|
|||
Some preparation is required for a smooth transition from one network version to another for node operators. Usually, this entails upgrading the node version only to a specified one before the upgrade - teams do their best to offer a final binary at least a week before the upgrade date. | |||
Some preparation is required for a smooth transition from one network version to another for node operators. Usually, this eentails upgrading to the node version only to a specified one before the upgrade - teams do their best to offer a final binary at least a week before the upgrade date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect.
::: | ||
|
||
## Avoiding migrations / node recovery | ||
|
||
Sometimes, it is not feasible to perform a network migration. If a node is hosted on a bare-metal server and not on a VPS, it might not be easy to have it upgraded. Fortunately, there is a way to avoid the painful migrations - Filecoin snapshots. The same applies when encountering an issue with your node (failing to follow the chain errors, consensus issues) - you should bootstrap the node from a fresh snapshot. | ||
Sometimes, it is not feasible to perform a network migration. If a node is hosted on a bare-metal server and not on a VPS, it might not be easy to have it upgraded. Fortunately, there is a way to avoid the painful migrations - Filecoin snapshots. The same applies when encountering an issue with your node (ffailing to follow chain errors, consensus issues) - you should bootstrap the node from a fresh snapshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect.
@@ -11,7 +11,7 @@ | |||
<p align="center"> | |||
<a href="https://github.com/ChainSafe/forest/blob/main/LICENSE-APACHE"><img alt="License Apache 2.0" src="https://img.shields.io/badge/License-Apache%202.0-blue.svg?style=for-the-badge"></a> | |||
<a href="https://github.com/ChainSafe/forest/blob/main/LICENSE-MIT"><img alt="License MIT" src="https://img.shields.io/badge/License-MIT-yellow.svg?style=for-the-badge"></a> | |||
<a href="https://twitter.com/ChainSafeth"><img alt="Twitter" src="https://img.shields.io/twitter/follow/chainsafeth?style=for-the-badge&color=1DA1F2"></a> | |||
<a href="https://x.com/ChainSafeth"><img alt="Twitter" src="https://img.shields.io/x/follow/chainsafeth?style=for-the-badge&color=1DA1F2"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as in README.
@@ -3,41 +3,41 @@ | |||
## Requirements | |||
|
|||
1. `forest` node running locally | |||
2. `docker` & `docker compose` must be available in the `$PATH` (alternatively | |||
2. `docker` & `docker-compose` must be available in the `$PATH` (alternatively |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker compose
is a valid subcommand for the new compose 2.x. docker-compose
is 1.x.
3. Port `3000` for `Grafana` has to be free. | ||
4. Port `3100` for `Loki` has to be free. | ||
|
||
## Run | ||
|
||
To run the metrics stack, use the provided Docker compose file to spawn the | ||
`prometheus`, `loki` and `grafana` containers. | ||
To run the metrics stack, use the provided docker-compose file to spawn the | ||
`prometheus`, `Loki` and `Grafana` containers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect.
Closing as it looks like an automated PR with plenty of obvious errors. Feel free to open a new one if this is not the case. |
fix: update URLs, correct spelling, and improve phrasing