Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): rename lib name from forest_filecoin to forest #5123

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(tracing): rename lib name from forest_filecoin to forest #5123

merged 1 commit into from
Jan 13, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jan 10, 2025 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • shorten forest_filecoin to forest in log

Reference issue to close (if applicable)

Closes #4649

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review January 10, 2025 12:37
@hanabi1224 hanabi1224 requested a review from a team as a code owner January 10, 2025 12:37
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team January 10, 2025 12:37
@hanabi1224 hanabi1224 requested a review from ansermino January 10, 2025 12:56
@ansermino
Copy link
Member

🤩

LesnyRumcajs
LesnyRumcajs approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change for anyone using forest-filecoin as a crate?

@hanabi1224
Copy link
Contributor Author

Is this a breaking change for anyone using forest-filecoin as a crate?

@LesnyRumcajs true, but I doubt anyone really does this : )

@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit fcccb3d Jan 13, 2025
44 checks passed
@hanabi1224 hanabi1224 deleted the hm/rename-lib-name branch January 13, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmattic elmattic elmattic approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

@ansermino ansermino Awaiting requested review from ansermino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove crate name from logs
4 participants
@hanabi1224 @ansermino @LesnyRumcajs @elmattic