fix(f3): F3 sidecar should work with Kademlia disabled #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1123c90 to
994b9da
Compare
9831610 to
a1f8275
Compare
a1f8275 to
fc58928
Compare
elmattic
approved these changes
Jan 7, 2025
LesnyRumcajs
reviewed
Jan 7, 2025
| $FOREST_PATH --chain calibnet --encrypt-keystore false --mdns false --kademlia false --auto-download-snapshot --log-dir "$LOG_DIRECTORY" --detach --save-token ./admin_token | ||
| $FOREST_PATH --chain calibnet --encrypt-keystore false --mdns false --kademlia false --auto-download-snapshot --log-dir "$LOG_DIRECTORY" --save-token ./admin_token & | ||
| FOREST_NODE_PID=$! | ||
| sleep 10s # to allow admin_token being saved |
There was a problem hiding this comment.
Let's avoid sleeping (and potential flakiness) by first running Forest with --exit-after-init and then starting the node in the background. Would that work?
There was a problem hiding this comment.
Great idea! Fixed.
|
No green checkmark! |
c54f2b0 to
9b75b0e
Compare
LesnyRumcajs
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR introduces a second internal Kademlia for bootstrapping F3 when the node Kademlia is disabled.
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #5065
Other information and links
Change checklist