Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable F3 FFI build on non x86_64 archs #4764

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: disable F3 FFI build on non x86_64 archs #4764

merged 1 commit into from
Sep 12, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Sep 12, 2024 •
edited
Loading

Summary of changes

arm64 is disabled for now as cross-compilation(used in Dockerfile) is not yet supported in rust2go and it's reported rust2go build does not work on arm64 MacOS

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review September 12, 2024 12:50
@hanabi1224 hanabi1224 requested a review from a team as a code owner September 12, 2024 12:50
@hanabi1224 hanabi1224 requested review from ruseinov and sudo-shashank and removed request for a team September 12, 2024 12:50
@elmattic elmattic added this pull request to the merge queue Sep 12, 2024
@elmattic
Copy link
Contributor

Works on my machine ™️

Merged via the queue into main with commit f4f57c2 Sep 12, 2024
33 checks passed
@elmattic elmattic deleted the hm/no-f3-ffi-on-arm64 branch September 12, 2024 14:53
@hanabi1224 hanabi1224 mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-shashank sudo-shashank sudo-shashank approved these changes

@elmattic elmattic elmattic approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanabi1224 @elmattic @sudo-shashank