Implement Wallet #469
Merged
Implement Wallet #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
suggested changes
Jun 4, 2020
ec2
reviewed
Jun 8, 2020
| } | ||
|
|
||
| #[derive(Default, Clone, PartialEq, Debug, Eq)] | ||
| pub struct MemKeyStore { |
There was a problem hiding this comment.
Won't keys need to be persisted? Is there a plan for that?
There was a problem hiding this comment.
This is just in memory storage, when the node stops and starts again, these keys are lost. There should be a way to persist the keys to be reused in some way
austinabell
reviewed
Jun 9, 2020
ec2
approved these changes
Jun 10, 2020
austinabell
approved these changes
Jun 10, 2020
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #464