feat(rpc) Implement WalletSignMessage #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatifsyed
approved these changes
Jul 11, 2024
src/rpc/methods/wallet.rs
Outdated
| let sig = crate::key_management::sign( | ||
| *key.key_info.key_type(), | ||
| key.key_info.private_key(), | ||
| message.cid().unwrap().to_bytes().as_slice(), |
There was a problem hiding this comment.
I'm surprised that you're ok with panicking in this handler
There was a problem hiding this comment.
I copy-pasted the signing code, and I didn't have the mental fortitude to fix the root cause. Hashing a message should be infallible but untangling that spaghetti will be rough.
There was a problem hiding this comment.
I think I'd prefer an expect("<here's why this is impossible>") or a ticket link instead :)
hanabi1224
approved these changes
Jul 12, 2024
aatifsyed
approved these changes
Jul 12, 2024
sudo-shashank
approved these changes
Jul 15, 2024
LesnyRumcajs
approved these changes
Jul 15, 2024
Nice! Our testing framework is even better than I thought. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
WalletSignMessage- this signs the CID of a message and returns aSignedMessage.Reference issue to close (if applicable)
Closes #4510
Other information and links
Change checklist