Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc) Implement Filecoin.EthProtocolVersion #4513

Merged
merged 10 commits into from
Jul 15, 2024
Merged

feat(rpc) Implement Filecoin.EthProtocolVersion #4513

merged 10 commits into from
Jul 15, 2024

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Jul 11, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Implement Filecoin.EthProtocolVersion RPC method
  • API compare tests
| RPC Method                  | Forest | Lotus |
|-----------------------------|--------|-------|
| Filecoin.EthProtocolVersion | Valid  | Valid |

Reference issue to close (if applicable)

Contributes to #4165

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@sudo-shashank sudo-shashank marked this pull request as ready for review July 11, 2024 11:23
@sudo-shashank sudo-shashank requested a review from a team as a code owner July 11, 2024 11:23
@sudo-shashank sudo-shashank requested review from ruseinov and hanabi1224 and removed request for a team July 11, 2024 11:23
@sudo-shashank sudo-shashank added this pull request to the merge queue Jul 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 12, 2024
sudo-shashank and others added 3 commits July 12, 2024 18:38
@sudo-shashank
feat(rpc) Implement Filecoin.EthGetTransactionHashByCid (#4506)
3bd24a9
@LeshyBot @github-merge-queue
@lemmih @sudo-shashank
[automated] Update Lotus version in API tests (#4520)
dc319d3 
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
Co-authored-by: David Himmelstrup <david.himmelstrup@chainsafe.io>
@sudo-shashank
Merge branch 'main' into shashank/Rpc-EthProtocolVersion
095c320
LesnyRumcajs
LesnyRumcajs reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a changelog entry?

@sudo-shashank sudo-shashank added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit ffa9312 Jul 15, 2024
28 checks passed
@sudo-shashank sudo-shashank deleted the shashank/Rpc-EthProtocolVersion branch July 15, 2024 14:14
sudo-shashank added a commit that referenced this pull request Jul 16, 2024
@sudo-shashank @lemmih
@LeshyBot @github-merge-queue
feat(rpc) Implement Filecoin.EthProtocolVersion (#4513)
c2c3bf2 
Co-authored-by: David Himmelstrup <david.himmelstrup@chainsafe.io>
Co-authored-by: LeshyBot <114995399+LeshyBot@users.noreply.github.com>
Co-authored-by: github-merge-queue <118344674+github-merge-queue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs left review comments

@aatifsyed aatifsyed aatifsyed approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

@lemmih lemmih Awaiting requested review from lemmih

@hanabi1224 hanabi1224 Awaiting requested review from hanabi1224

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sudo-shashank @lemmih @hanabi1224 @LesnyRumcajs @aatifsyed @LeshyBot