test: check compatibility for three more RPC calls #3698
Merged
+69
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatifsyed
suggested changes
Nov 10, 2023
| @@ -4,11 +4,16 @@ | |||
| use super::*; | |||
| use crate::shim::crypto::SignatureType; | |||
|
|
|||
| // Lotus uses signature types under two names: `KeyType` and `SigType`. | |||
| // `KeyType` can be deserialized from a string but `SigType` must always be an | |||
| // integer. For more information, see | |||
There was a problem hiding this comment.
Shouldn't we add lenses for SignatureType to cover these two cases?
There was a problem hiding this comment.
Not sure what you mean by this. Matching Lotus' behavior exactly will require some refactoring that is out of scope of this PR.
4 tasks
hanabi1224
approved these changes
Nov 22, 2023
aatifsyed
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
StateLookupIDStateNetworkVersionWalletBalanceSignatureTypeto always be encoded as an integer. Lotus requires this in certain places.Reference issue to close (if applicable)
Part of #3639
Other information and links
Change checklist