Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add const FOREST_CAR_FILE_EXTENSION to avoid hard codings #3427

Merged
merged 2 commits into from
Aug 30, 2023
Merged

chore: add const FOREST_CAR_FILE_EXTENSION to avoid hard codings #3427

merged 2 commits into from
Aug 30, 2023

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Aug 30, 2023 •
edited
Loading

Summary of changes

As follow up of #3365 (comment)

Changes introduced in this pull request:

  • add const FOREST_CAR_FILE_EXTENSION to avoid hard codings

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 mentioned this pull request Aug 30, 2023
Merged
4 tasks
@hanabi1224 hanabi1224 marked this pull request as ready for review August 30, 2023 10:55
@hanabi1224 hanabi1224 requested a review from a team as a code owner August 30, 2023 10:55
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team August 30, 2023 10:55
@hanabi1224 hanabi1224 force-pushed the hm/const-forest-car-ext branch from 3d18f36 to 62e96c6 Compare August 30, 2023 11:07
@hanabi1224 hanabi1224 added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 2129e5d Aug 30, 2023
@hanabi1224 hanabi1224 deleted the hm/const-forest-car-ext branch August 30, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@lemmih lemmih lemmih approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanabi1224 @lemmih @LesnyRumcajs