Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forest tool migration of forest-cli subcommands #3336

Merged
merged 60 commits into from
Aug 18, 2023
Merged

Forest tool migration of forest-cli subcommands #3336

merged 60 commits into from
Aug 18, 2023

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Aug 8, 2023 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Moved the following forest-cli subcommands to forest-tool:
    • archive info
    • fetch-params
    • snapshot fetch
    • snapshot validate

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

lemmih
lemmih reviewed Aug 8, 2023
View reviewed changes
src/tool/main.rs Outdated Show resolved Hide resolved
lemmih
lemmih reviewed Aug 8, 2023
View reviewed changes
src/tool/main.rs Outdated
Comment on lines 16 to 17
let opts = CliOpts::default();
let path = find_config_path(&opts);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no CliOpts here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I can create a small util find_config_path that doesn't require opts, sounds ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you find non-default configuration paths without taking any arguments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, this is missing for now but will handle that case.

elmattic added 23 commits August 8, 2023 13:33
@elmattic
Migrate fetch-params subcommand
2368ca7
@elmattic
Merge branch 'main' into elmattic/forest-tool-migration
2f46a5f
@elmattic
Move Config to commands that require it
ae61c2f
@elmattic
Migrate snapshot fetch and validate subcommands
d13a849
@elmattic
Remove string manipulations
c6df6ae
@elmattic
Migrate archive info subcommand
355aa7e
@elmattic
Remove all duplicated strings
11c0442
@elmattic
Use dedicated flag
cf05e60
@elmattic
Rename DB clean subcommand
f4dbb70
@elmattic
Add optional config file
2405b4e
@elmattic
Merge branch 'main' into elmattic/forest-tool-migration
55ad715
@elmattic
Update harness script
5bacfc8
@elmattic
Update other scripts
a986ee4
@elmattic
Use toml file instead
7d87792
@elmattic
Merge branch 'main' into elmattic/forest-tool-migration
ce05ce0
@elmattic
Add back db clean and db stats subcommands
45c9d95
@elmattic
Update calls to snapshot fetch
2b513be
@elmattic
Merge branch 'main' into elmattic/forest-tool-migration
fa26642
@elmattic
Remove forest-tool db subcommands (will be in a dedicated PR)
5910f10
@elmattic
Remove second pattern
035f5d4
@elmattic
Update CHANGELOG
7cfb7b0
@elmattic
Fix shell script
6ff4c34
@elmattic
Fix: chain flag is not needed for snapshot validate
fb3b711
@elmattic
Copy link
Contributor Author

It'd be great to mention somewhere in the README the current structure of Forest binaries.

👍

The Dockerfile check needs to be updated.

The release workflow needs to be updated.

Do I need to update those files in this branch?

@elmattic
Copy link
Contributor Author

The Dockerfile check needs to be updated.

The release workflow needs to be updated.

I've updated those files. Lmk if it's good.

LesnyRumcajs
LesnyRumcajs approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a PR ready in forest-iac to deal with breaking changes, so we don't have to quickly fix things after a new release.

Dockerfile Show resolved Hide resolved
src/cli/main.rs Outdated Show resolved Hide resolved
src/cli/subcommands/snapshot_cmd.rs Show resolved Hide resolved
@elmattic elmattic mentioned this pull request Aug 16, 2023
Merged
@elmattic
Copy link
Contributor Author

Let's have a PR ready in forest-iac to deal with breaking changes, so we don't have to quickly fix things after a new release.

Here's the PR (draft): ChainSafe/forest-iac#216

@elmattic elmattic added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit e56da0a Aug 18, 2023
@elmattic elmattic deleted the elmattic/forest-tool-migration branch August 18, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@lemmih lemmih lemmih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmattic @lemmih @LesnyRumcajs