Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: demote noisy warnings to debug #1518

Merged
merged 5 commits into from
Mar 31, 2022
Merged

node: demote noisy warnings to debug #1518

merged 5 commits into from
Mar 31, 2022

Conversation

q9f
Copy link
Contributor

@q9f q9f commented Mar 30, 2022

info, warn, and error should only be used if it is relevant for the user, not the developer.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1518 (615bd18) into main (003308a) will not change coverage.
The diff coverage is 8.00%.

@@           Coverage Diff           @@
##             main    #1518   +/-   ##
=======================================
  Coverage   44.42%   44.42%           
=======================================
  Files         310      310           
  Lines       28112    28112           
=======================================
  Hits        12488    12488           
  Misses      15624    15624           
Impacted Files Coverage Δ
blockchain/chain_sync/src/chain_muxer.rs 1.74% <0.00%> (ø)
blockchain/chain_sync/src/network_context.rs 0.00% <0.00%> (ø)
forest/src/cli/mod.rs 0.00% <0.00%> (ø)
forest/src/daemon.rs 6.29% <0.00%> (ø)
node/forest_libp2p/src/behaviour.rs 0.00% <0.00%> (ø)
utils/paramfetch/src/lib.rs 64.36% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003308a...615bd18. Read the comment docs.

@q9f
Copy link
Contributor Author

q9f commented Mar 31, 2022

@LesnyRumcajs I bumped the incorrect password messages to ``error!`

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs I bumped the incorrect password messages to ``error!`

Sounds good, if someone suppresses even errors then we no longer take responsibility for that. 😄

@q9f q9f merged commit e35099f into main Mar 31, 2022
@q9f q9f deleted the q9f/log/debug branch March 31, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants