feat: add statistical convergence and outlier detection #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
reviewed
Jan 27, 2025
| @@ -65,6 +65,10 @@ export type BenchmarkOpts = { | |||
| setupFiles?: string[]; | |||
| /** Trigger GC cleanup every test to have consistent memory usage */ | |||
| triggerGC?: boolean; | |||
| /** The algorithm to detect the convergence to stop the benchmark function runs */ | |||
| convergence?: "linear" | "cv"; | |||
There was a problem hiding this comment.
what does cv mean? maybe include a brief description of each in the docstring
There was a problem hiding this comment.
Added the detailed comments.
wemeetagain
reviewed
Jan 27, 2025
wemeetagain
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure the benchmark have stable results in the unstable environments.
Description
Steps to test or reproduce