Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export afterEach and afterAll hooks #23

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: export afterEach and afterAll hooks #23

merged 2 commits into from
Jan 17, 2025

Conversation

nazarhussain
Copy link

Motivation

Support after* hooks for life cycle cleanup.

Description

  • Expose the after* hooks

Steps to test or reproduce

  • Run all tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 7001cd8 Previous: null Ratio
sum array with raw for loop 933.10 us/op
sum array with reduce 10.265 ms/op
sum array with reduce beforeEach 10.177 ms/op
sum array with reduce before beforeEach 9.9290 ms/op
sum array with reduce high threshold 10.231 ms/op
sum array with reduce no threshold 10.349 ms/op

by benchmarkbot/action

matthewkeil
matthewkeil approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

@nazarhussain nazarhussain merged commit dfe1220 into main Jan 17, 2025
13 checks passed
@nazarhussain nazarhussain deleted the nh/export-after-hooks branch January 17, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewkeil matthewkeil matthewkeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazarhussain @matthewkeil