Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort the files before running #18

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: sort the files before running #18

merged 1 commit into from
Jan 14, 2025

Conversation

nazarhussain
Copy link

Motivation

Sort files to natural order, the way it was executed before in the mocha.

Description

  • Fix sort order of files, that is impacting the performance of each benchmark a lot.

Steps to test or reproduce

  • Run all tests

Copy link

github-actions bot commented Jan 14, 2025

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 8a8e1cc Previous: null Ratio
sum array with raw for loop 935.66 us/op
sum array with reduce 10.187 ms/op
sum array with reduce beforeEach 10.100 ms/op
sum array with reduce before beforeEach 10.323 ms/op
sum array with reduce high threshold 10.307 ms/op
sum array with reduce no threshold 10.274 ms/op

by benchmarkbot/action

@nazarhussain nazarhussain merged commit 2cffa83 into main Jan 14, 2025
13 checks passed
@nazarhussain nazarhussain deleted the nh/sort-files branch January 14, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant