Adding imagelayers link to search results #532
Conversation
| @@ -12,7 +12,8 @@ | |||
| status_label: 'Local', | |||
| badge_class: 'local', | |||
| star_count: 123, | |||
| docker_index_url: 'index.docker/boom/shaka' | |||
| docker_index_url: 'index.docker/boom/shaka', | |||
| imagelayers_url: 'imagelayers.io/?images=boom/shaka' | |||
There was a problem hiding this comment.
How about
imagelayers_url: "#{IMAGELAYERS_URL}?images=boom/shaka"
|
👍 |
adf0dc7 to
2ea1734
Compare
|
👍 |
2ea1734 to
667576a
Compare
| @@ -39,6 +39,15 @@ def docker_index_url | |||
| end | |||
| end | |||
|
|
|||
| def imagelayers_url | |||
| if remote? | |||
There was a problem hiding this comment.
Not that big of a deal, but it would probably be better to put these implementations into the child classes that are inheriting from this base. The example set above (line 36) is a bad one, that creates a bi-directional dependency... This super class shouldn't really have knowledge of the child classes. There's also a missing test for the remote image case, I think. Though it gets tested implicitly in the as_json tests...
There was a problem hiding this comment.
Yeah, I had the same thought, though wanted to stay with the existing pattern we use for the hub url. I'll refactor when I add the IL links to the application page (and add that missing test).
Adding imagelayers icon next to remote images in both the main search results as well as the modal. Behavior is the same as on the image list page.
