Feature/delete multiple images 77123524 #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -705,3 +706,52 @@ pre.prettyprint { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| .styled-check { | |||
4d185d8 to
9d4c6fe
Compare
| @@ -29,6 +29,10 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe '#batch_destroy' do | |||
5d2dd42 to
644354b
Compare
|
👍 |
| base.checkboxStateHandler = function(e) { | ||
| var $target = $(e.currentTarget); | ||
|
|
||
| if($target.is(':checked')) { |
There was a problem hiding this comment.
optionally, I think you could just do something like this:
var checked = $target.is(':checked');
base.$el.find(base.options.deleteCheckbox).prop('checked', checked);
644354b to
9369f1d
Compare
|
|
||
| def self.batch_destroy(image_ids) | ||
| count = 0 | ||
| fail_list = image_ids.each_with_object(Set.new) do |id, fail_list| |
There was a problem hiding this comment.
Shadowing outer local variable - fail_list.
9369f1d to
81900ab
Compare
| expect(response).to redirect_to images_url | ||
| end | ||
|
|
||
| it '' |
|
👍 - after removing the empty it |
|
👍 |
|
|
||
| private | ||
|
|
||
| def build_message(result) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[finishes: #77123524]
[finishes: #78768594]
Allows users to multi select images but removes the checkbox option for panamax images.