Don't modify receiver when fixing name.

[fixes #93470440]
CenturyLinkLabs · Apr 28, 2015 · 80715bd · 80715bd
1 parent 8a65544
commit 80715bd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/app/controllers/deployment_targets_controller.rb b/app/controllers/deployment_targets_controller.rb
@@ -39,7 +39,7 @@ def token
   private
 
   def sanitize_filename(name)
-    name.gsub!(/[^0-9A-Za-z.\-]/, '_')
+    name.gsub(/[^0-9A-Za-z.\-]/, '_')
   end
 
   def hydrate_index_view

diff --git a/spec/controllers/deployment_targets_controller_spec.rb b/spec/controllers/deployment_targets_controller_spec.rb
@@ -29,6 +29,16 @@
       )
       get :token, id: 7
     end
+
+    it 'properly sanitizes names' do
+      allow(fake_target).to receive(:name).and_return('foo')
+      expect(controller).to receive(:send_data).with(
+        'blob',
+        filename: 'foo.txt',
+        type: 'text/plain'
+      )
+      get :token, id: 7
+    end
   end
 
   describe 'GET #index' do