Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAM-13224]: use pylint and futurize to make code Python3-ready #49

Merged
merged 2 commits into from
Apr 9, 2020
Merged

[CAM-13224]: use pylint and futurize to make code Python3-ready #49

merged 2 commits into from
Apr 9, 2020

Conversation

grrtrr
Copy link
Contributor

@grrtrr grrtrr commented Dec 12, 2019

This adds changes to support Python3 in the APIv2 code.

[CAM-13224]: use pylint and futurize to make code Python3-ready
08a4a71 
This adds changes to support Python3 in the APIv2 code.
EfrenRey
EfrenRey reviewed Jan 14, 2020
View reviewed changes
Copy link
Contributor

@EfrenRey EfrenRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a minor comment. Please, take a look, thanks.

jinzishuai
jinzishuai suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jinzishuai jinzishuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grrtrr Please also update https://github.com/CenturyLinkCloud/clc-python-sdk/blob/master/README.md where it currently says no support for Python-3 and add some proper instructions for the support of both python-2.7 and python-3.

@grrtrr
Copy link
Contributor Author

grrtrr commented Jan 15, 2020 •
edited
Loading

@grrtrr Please also update https://github.com/CenturyLinkCloud/clc-python-sdk/blob/master/README.md where it currently says no support for Python-3 and add some proper instructions for the support of both python-2.7 and python-3.

I have removed the comment saying that Python3 is not supported. The PR has the necessary modifications for listing on PyPi: when they upload the new clc-sdk, this should mark the package as Python3-enabled on PyPi.

@EfrenRey EfrenRey merged commit 707e8b1 into CenturyLinkCloud:master Apr 9, 2020
@jinzishuai
Copy link
Contributor

test results of the CAM Cloud Tests in CLC running in a python-3 testbed after removing the billing code (https://github.com/jinzishuai/elasticbox/commit/99e651d9cabeeb1a198dffea37d85f2c10810116)
http://10.55.220.31:8080/view/CAM/job/CAM-Platform-ALM/job/ALM-Appliance-CloudTest/28/testReport/
image

@grrtrr grrtrr deleted the CAM_13224 branch April 9, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinzishuai jinzishuai jinzishuai requested changes

@EfrenRey EfrenRey EfrenRey approved these changes

@Ahhmyface Ahhmyface Ahhmyface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grrtrr @jinzishuai @EfrenRey @Ahhmyface