[No ticket] Remove bower #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
requested changes
Jun 22, 2023
package.json
Outdated
| @@ -112,7 +111,9 @@ | |||
| "url": "https://github.com/CenterForOpenScience/ember-osf-preprints/issues" | |||
| }, | |||
| "homepage": "https://github.com/CenterForOpenScience/ember-osf-preprints#readme", | |||
| "dependencies": {}, | |||
| "dependencies": { | |||
| "jquery-tags-input": "^1.3.5" | |||
There was a problem hiding this comment.
This should probably be in dev-dependencies
brianjgeiger
approved these changes
Jun 23, 2023
adlius
pushed a commit
that referenced
this pull request
Sep 7, 2023
## Purpose - Remove bower and hopefully have stuff build on jenkins ## Summary of Changes/Side Effects - Removed bower and references to it - Added remaining dependencies in bower.json to package.json - Remove ember-sanitize as it is still using bower in favor of ember-cli-string-helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes/Side Effects
Testing Notes
Ticket
[No ticket]
Notes for Reviewer
Reviewer Checklist
CHANGELOG.md