Fix a11y problems on discover page

CenterForOpenScience · Jul 20, 2021 · 8a68b0e · 8a68b0e
1 parent a120a49
commit 8a68b0e
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -16,6 +16,8 @@
 /libpeerconnection.log
 npm-debug.log
 testem.log
+.yalc
+yalc.lock
 
 # idea
 .idea
diff --git a/app/index.html b/app/index.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html prefix="og: http://ogp.me/ns#">
+<html prefix="og: http://ogp.me/ns#" lang="en-us">
   <head>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">

diff --git a/app/locales/en/translations.js b/app/locales/en/translations.js
@@ -41,6 +41,8 @@ export default {
         license: 'License',
         pre_moderation: 'pre-moderation',
         post_moderation: 'post-moderation',
+        collapse: 'Collapse',
+        expand: 'Expand',
     },
     application: {
         separator: ' | ',

diff --git a/app/templates/components/provider-carousel.hbs b/app/templates/components/provider-carousel.hbs
@@ -10,12 +10,14 @@
                                 onclick={{action 'selectProvider' provider}}
                                 disabled={{eq provider activeProvider}}
                                 title="{{provider.name}}"
+                                role='option'
                                 style={{safe-markup (concat "background-image: url('" (provider-asset provider.id 'square_color_no_transparent.png') "')")}} />
                         </div>
                     {{else}}
                         <div class={{if (not index) (concat "col-sm-2 " columnOffset) "col-sm-2"}}>
                             <a href="{{branded-preprint-url provider path=(if lightLogo '' '/discover')}}"
                                 title={{provider.name}}
+                                role='option'
                                 onclick={{action 'click' 'link' (concat 'Index - Provider Carousel - ' provider.name)}}
                                 >
                                 {{#if lightLogo}}

diff --git a/app/templates/components/search-facet-taxonomy.hbs b/app/templates/components/search-facet-taxonomy.hbs
@@ -2,7 +2,12 @@
     <ul>
         {{#each topLevelItem as |item|}}
             <li>
-                <span role="button" class="pointer m-r-xs {{if item.showChildren 'taxonomy-show-children'}}" {{action 'expand' item}}>
+                <span
+                    role="button"
+                    class="pointer m-r-xs {{if item.showChildren 'taxonomy-show-children'}}"
+                    {{action 'expand' item}}
+                    aria-label="{{if item.showChildren (t 'global.collapse') (t 'global.expand')}} {{item.text}}"
+                >
                     <i class="taxonomy-caret fa {{if item.showChildren 'fa-caret-down' 'fa-caret-right'}}"></i>
                 </span>
                 <label class="taxonomy-checkbox">

diff --git a/package.json b/package.json
@@ -25,7 +25,7 @@
     "hotfix": "git flow hotfix start rename-me && npm --no-git-tag-version version patch && git ci package.json -m 'Bump version' && git br -m \"hotfix/$(npm version | head -1 | grep -o '[0-9]\\+\\.[0-9]\\+\\.[0-9]\\+')\""
   },
   "devDependencies": {
-    "@centerforopenscience/ember-osf": "https://github.com/CenterForOpenScience/ember-osf.git#0.31.1",
+    "@centerforopenscience/ember-osf": "https://github.com/CenterForOpenScience/ember-osf.git#0.31.2",
     "@centerforopenscience/eslint-config": "^2.0.0",
     "@centerforopenscience/osf-style": "1.9.0",
     "autoprefixer": "^7.1.2",