Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notification not displaying on non-English systems #23

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Fix notification not displaying on non-English systems #23

merged 1 commit into from
Dec 14, 2024

Conversation

Celve
Copy link
Owner

@Celve Celve commented Dec 14, 2024

Problems:

  • The AX title name matches the localized name of the NSRunningApp. On English systems, the CFBundleName is identical to the AX title name, but on non-English systems, they differ.

Solutions:

  • Use the bundle ID to retrieve the localized name instead of relying on the CFBundleName directly.

@Celve Celve marked this pull request as ready for review December 14, 2024 09:31
@Celve Celve merged commit bc76e36 into main Dec 14, 2024
@martinengelke martinengelke mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Celve