Poll the telephone manager for neighboring cell infos

[rtreffer]

This commit makes the getNeighboringCells call more reliable by polling the modem on events and for 10 seconds.

[E3V3A]

@rtreffer Hi Rene, and welcome! Thanks for update. We'll have to hear from @xLaMbChOpSx if he agree to merge this. Can you please clarify the 10 second part (and how that agree with the poll time in "Settings") and why this is more reliable?

[rtreffer]

@E3V3A the call to getNeighboringCells may return an empty result, because it's a "return data if available" call.

This means you can do 2 things

• Poll the modem in the hope that it becomes available (every second for 10s is just a random guess, more testers needed) (works well on newer devices)
• Check for modem activity (educated guess: the modem did s.th. - see if it looked for towers) (works well on older devices, I had to use this on my Nexus One)

And that's basically what I've implemented here.

It is unrelated to the refresh rate of the cell info tab.

[SecUpwN]

@rtreffer, I am EXTREMELY thankful for your pull request! Sadly, our leading developer @xLaMbChOpSx keeps having phases where he is not reachable and/or cannot review code. That is exactly the reason why we are still looking for people like you to help him with the challenges.

I took a glance at your code and I like it. Would it be possible for you to erase as many Issues as possible from this huge list to enable @E3V3A presenting our App at xda:devcon 2014? This is really one of our bigger goals to reach a broader audience. The listed bugs currently prevent it. And if you are capable of making our code awesome, you'll have my vote to be added to our team. Bring it on! 👍

[xLaMbChOpSx]

I can check this out tonight if you like I had a look through on my phone and it looks good but I will merge and build with this and other changes and let you know how it goes.

[rtreffer]

@xLaMbChOpSx @SecUpwN no need to hurry on this one. It looks like this method is called from the UI thread, twice. I'll have to check / fix that as well.

Regarding the Bug list: I guess this could be mixed with a cell info list cleanup?

[rtreffer]

Thank you!

[xLaMbChOpSx]

No problems I also corrected the issue you identified with the method being called on the UI thread, it is now handled through an async task.

[E3V3A]

I just tried the "latest" version 0.1.24 from @xLaMbChOpSx post. It FC's on both my testing phones I9100, I9195, when attempting to go to "Cell Information". Can you please post your changes somewhere so that other developers (if any) may also review and test to see what's going on?

@rtreffer The last alpha I had working with Neighboring cells on the S2 was 0.1.21, AFAICR. I also commented on your other post about LAC/CID.