-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module Version 2.3.0 - Update SaaS and other Help docs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated links in contributing docs to link to project repo, also updates other comment based help in the functions.
Update the Set-DattoBulkSeatChange function parameters to accept pipeline input, and by property name to match other params in the function
The endpoint accept a '0' value, which is different from not including the parameter, by default with no parameter set the API returns 10 days of historical data. With 0 value, only remote IDs can be returned if chosen by the module user. Since the API accepts the '0' value we should include it as well as valid input.
Updated some wording, removed extra lines, changed SaaS customer ID to 6 digit format
Updated help comments for SaaS Application endpoint, currently documented values added for reference
Require strict strongly typed parameters with the use of casting as enums rather than string. This is to better align with changes reflected from Datto
Provides examples for O365 and GWS valid seat types. Added reference to Google Seat Management and stipulation API endpoint does not function for SM 1.0 Link to Datto documentation - This external link could possibly change in the future so we may not wish to include in prod.
Updated $saasCustomerId var to [int] type when casting parameter to better match Datto Partner Portal Swagger documentation for expected value for customerId from bulkSeatChange endpoint.
Updated links to project repo under .github folder to point to proper URL
Updated help comments for SaaS Application endpoint, currently documented values added for reference. Also updated PR template with deprecated dev branch missed prior
Thank you very much again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module Version 2.3.0 - Update SaaS and other Help docs
Mostly just lots of small changes centered around the SaaS API endpoints, and other miscellaneous help documentation
$saasCustomerId
parameter from<string>
to<int>
type, as documented in Datto's Swagger file.$daysUntil
parameter range to accept '0' value as this is also accepted by the endpointContributes: #4
Type of change
Checklist
How Has This Been Tested?
int
type documented in Swagger for API properly calls endpoint as expected with change from<string>