Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CanonicalEnsemble and SemigrandEnsemble + some minor fixes #257

Merged
merged 4 commits into from
Sep 3, 2022
Merged

Remove CanonicalEnsemble and SemigrandEnsemble + some minor fixes #257

merged 4 commits into from
Sep 3, 2022

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Sep 3, 2022

Summary

  • Remove deprecated CanonicalEnsemble and SemigrandEnsemble classes.
  • use int and bool instead of np.int and np.bool
  • add a few filter warnings to unit tests

Checklist

@lbluque lbluque merged commit 33952fc into CederGroupHub:main Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lbluque