Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for fitting with centering #238

Merged
merged 3 commits into from
Jul 23, 2022
Merged

Add example for fitting with centering #238

merged 3 commits into from
Jul 23, 2022

Conversation

kamronald
Copy link
Collaborator

Summary

  • Added jupyter notebook to demonstrate piecewise fitting with centering on Pts and Ewald features

Additional dependencies introduced (if any)

TODO (if any)

Checklist

@lbluque lbluque self-requested a review July 23, 2022 01:07
lbluque
lbluque approved these changes Jul 23, 2022
View reviewed changes
Copy link
Collaborator

@lbluque lbluque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kamronald !

@lbluque lbluque merged commit a4802b7 into CederGroupHub:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbluque lbluque lbluque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamronald @lbluque