Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clustersubspaces with no orbits #158

Merged
merged 4 commits into from
Mar 1, 2022
Merged

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Mar 1, 2022

Summary

Allows creating a ClusterSubspace with only a constant term (ie excluding pointer terms as well), by passing None as the point cutoff

subspace = ClusterSubspace.from_cutoffs(prim, {1: None})

Also slightly refactored private method _gen_orbits_from_cutoffs to call a _gen_point_orbits and _gen_multi_orbits for cleaner code and to avoid duplicated code in PottsSubspace

TODO (if any)

Needs a few test updates to simply check that it works and that the exception there is raised.

Checklist

@lbluque
Copy link
Collaborator Author

lbluque commented Mar 1, 2022

merging. update tests with the bulk of updating to pytest.

@lbluque lbluque merged commit 1c1a4e0 into CederGroupHub:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant