Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate "Others", based on the aggregationType #922

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

jmgaya
Copy link
Contributor

@jmgaya jmgaya commented Nov 29, 2024

Description

Shortcut

rest-calculation.mp4

Type of change

  • Fix

@jmgaya jmgaya changed the title Fix REST_CATEGORY calculation, based on the aggregationType Calculate "Others", based on the aggregationType Nov 29, 2024
Copy link

Pull Request Test Coverage Report for Build 12086293080

Details

  • 9 of 15 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 70.888%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/CategoryWidgetUI/CategoryWidgetUI.js 9 15 60.0%
Totals Coverage Status
Change from base Build 11594407068: -0.05%
Covered Lines: 2896
Relevant Lines: 3758

💛 - Coveralls

Copy link
Contributor

@zbigg zbigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good too me,

Copy link

Visit the preview URL for this PR (updated for commit 5f35de0):

https://cartodb-fb-storybook-react-dev--pr922-bug-448703-fix-r-gfw9g6c7.web.app

(expires Fri, 06 Dec 2024 14:21:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@jmgaya jmgaya merged commit 775ba99 into master Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants