Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete creatable: improved API to cover more use cases #881

Merged
merged 16 commits into from
Jun 21, 2024
Merged

Autocomplete creatable: improved API to cover more use cases #881

merged 16 commits into from
Jun 21, 2024
+255 −42

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Jun 14, 2024 •
edited
Loading

vmilan
vmilan commented Jun 14, 2024
View reviewed changes
CHANGELOG.md
@@ -2,11 +2,14 @@

## Not released

- Forms fixes & improvements [#881](https://github.com/CartoDB/carto-react/pull/881)
- Fix LegendProportion radius scale [#877](https://github.com/CartoDB/carto-react/pull/877)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing entry from previous PR

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9584485119

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9584485119

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9584485119

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 57d1a77):

https://cartodb-fb-storybook-react-dev--pr881-feature-forms-fi-juuz01gx.web.app

(expires Fri, 28 Jun 2024 11:49:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9584834066

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9584834066

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9584834066

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@vmilan @Josmorsot
Apply suggestions from code review
eb1ddb3 
Co-authored-by: Ivan Moreno <imoreno@carto.com>
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9594169261

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9594169261

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9594169261

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9599356202

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9599356202

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9599356202

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9599451473

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9599451473

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9599451473

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.295%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/buttons.js 1 2 50.0%
Totals Coverage Status
Change from base Build 9554648464: 0.05%
Covered Lines: 2814
Relevant Lines: 3639
💛 - Coveralls

@vmilan vmilan changed the title Forms fixes & improvements Autocomplete creatable: improved API to cover more use cases Jun 20, 2024
@vmilan vmilan marked this pull request as ready for review June 20, 2024 15:35
@vmilan vmilan requested review from VictorVelarde and a team June 20, 2024 15:35
VictorVelarde
VictorVelarde approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9600331841

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9600304360

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

1 similar comment
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9600304360

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9600331841

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9600304360

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9600331841

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9611108983

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9612391962

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9612391962

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9612391962

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9613063598

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9613063598

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9613063598

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.245%
Totals Coverage Status
Change from base Build 9554648464: 0.0%
Covered Lines: 2811
Relevant Lines: 3635
💛 - Coveralls

@vmilan vmilan merged commit 3327465 into master Jun 21, 2024
2 checks passed
@vmilan vmilan deleted the feature/forms-fixes branch June 21, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroAlmonacidRojo AlvaroAlmonacidRojo AlvaroAlmonacidRojo approved these changes

@Josmorsot Josmorsot Josmorsot approved these changes

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
design system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vmilan @coveralls @VictorVelarde @Josmorsot @AlvaroAlmonacidRojo