Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable timeseries y axis #861

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

juandjara
Copy link
Contributor

@juandjara juandjara commented Apr 9, 2024

Description

Shortcut: https://app.shortcut.com/cartoteam/story/401311/ui-pdf-report-in-the-pdf-downloaded-the-time-series-widget-should-be-displayed-with-a-y-axis-with-a-scale-of-the-values

This PR depends on PR #860 (that PR should be merged before this one)

This is a PR with a feature required in the design QA phase of the PDF Report in Builder initiative

Type of change

  • Feature

Acceptance

Please describe how to validate the feature or fix

  1. Open C4R Storybook
  2. Go to story for TimeSeriesWidgetUI
  3. Select yAxisType as full
  4. it should look like this

Captura de pantalla 2024-04-09 a las 14 19 39 1

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

Copy link

github-actions bot commented Apr 9, 2024

Pull Request Test Coverage Report for Build 8627891374

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 9 (55.56%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 68.377%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/TimeSeriesWidgetUI/components/TimeSeriesChart.js 5 9 55.56%
Files with Coverage Reduction New Missed Lines %
packages/react-ui/src/widgets/TimeSeriesWidgetUI/components/TimeSeriesChart.js 1 54.87%
Totals Coverage Status
Change from base Build 8627882200: -0.02%
Covered Lines: 2685
Relevant Lines: 3578

💛 - Coveralls

Copy link

github-actions bot commented Apr 9, 2024

Visit the preview URL for this PR (updated for commit 3301cfd):

https://cartodb-fb-storybook-react-dev--pr861-feature-configur-b93jb5ks.web.app

(expires Wed, 17 Apr 2024 08:04:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@padawannn padawannn merged commit d78a91d into master Apr 10, 2024
1 check passed
@padawannn padawannn deleted the feature/configurable-timeseries-y-axis branch April 10, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants