Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category widget UI: change focus order to increase keyboard accessibility #857

Merged
merged 12 commits into from
Mar 22, 2024

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Mar 21, 2024

Copy link

Copy link

github-actions bot commented Mar 21, 2024

Pull Request Test Coverage Report for Build 8388441781

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 68.584%

Totals Coverage Status
Change from base Build 8363429921: 0.08%
Covered Lines: 2652
Relevant Lines: 3524

💛 - Coveralls

Copy link

github-actions bot commented Mar 21, 2024

Visit the preview URL for this PR (updated for commit 89a50b7):

https://cartodb-fb-storybook-react-dev--pr857-feature-accesibl-kzi5lkm7.web.app

(expires Fri, 29 Mar 2024 09:56:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@vmilan vmilan requested a review from a team March 22, 2024 08:41
Copy link
Contributor

@AlvaroAlmonacidRojo AlvaroAlmonacidRojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VictorVelarde VictorVelarde self-requested a review March 22, 2024 10:40
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@vmilan vmilan merged commit 6ae8a6b into master Mar 22, 2024
2 checks passed
@vmilan vmilan deleted the feature/accesible-category-widget branch March 22, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants