Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Geometry Edit in Feature Selection #854

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

juandjara
Copy link
Contributor

@juandjara juandjara commented Mar 13, 2024

Description

Shortcut: https://app.shortcut.com/cartoteam/story/394555/feature-selection-edition-doesn-t-work

This PR fixes a bug with edition of geometries introduced in PR #847
Turns out nebula.gl features are immutable objects (enforced with the Object constructor) and cannot be edited in-place

Type of change

  • Fix

Acceptance

Please describe how to validate the feature or fix

  1. open carto workspace
  2. open or create a map
  3. add some data if none is present
  4. add a feature selection mask
  5. try to edit the mask or switch to a different edit mode
  6. feature selection tool should stay responsive and respond to edits

If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@juandjara juandjara requested a review from padawannn March 13, 2024 13:01
Copy link

github-actions bot commented Mar 13, 2024

Pull Request Test Coverage Report for Build 8265075577

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 68.534%

Files with Coverage Reduction New Missed Lines %
packages/react-widgets/src/layers/FeatureSelectionLayer.js 1 56.18%
Totals Coverage Status
Change from base Build 8201096907: 0.01%
Covered Lines: 2644
Relevant Lines: 3516

💛 - Coveralls

Copy link

github-actions bot commented Mar 13, 2024

Visit the preview URL for this PR (updated for commit 64f5fe4):

https://cartodb-fb-storybook-react-dev--pr854-fix-feature-sele-661b5bp8.web.app

(expires Wed, 20 Mar 2024 13:06:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@padawannn padawannn merged commit 2d13589 into master Mar 13, 2024
2 checks passed
@padawannn padawannn deleted the fix/feature-selection branch March 13, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants