Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Deck GL v9 #838

Merged
merged 29 commits into from
Apr 16, 2024
Merged

Update Deck GL v9 #838

merged 29 commits into from
Apr 16, 2024

Conversation

padawannn
Copy link
Contributor

@padawannn padawannn commented Feb 6, 2024 •
edited
Loading

  • Update to deck V9
  • Remove dropping features functionality
  • Adapt useCartoLayerProps to only return properties necessary to interact with the widget system

@padawannn padawannn requested a review from a team March 20, 2024 09:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8704831341

Details

  • 56 of 62 (90.32%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.9%) to 71.233%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-widgets/src/layers/EditableCartoGeoJsonLayer.js 0 1 0.0%
packages/react-widgets/src/models/fqn.js 52 57 91.23%
Totals Coverage Status
Change from base Build 8628083789: 2.9%
Covered Lines: 2797
Relevant Lines: 3617
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a204929):

https://cartodb-fb-storybook-react-dev--pr838-padawannn-deck-v-wcqd9cyr.web.app

(expires Tue, 23 Apr 2024 11:35:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@padawannn padawannn marked this pull request as ready for review April 15, 2024 11:34
@aaranadev
Copy link
Contributor

@padawannn, can you review all workspace dependencies?

I see "@carto/react-api": "^3.0.0-alpha.3", when the last version is "@carto/react-api": "^3.0.0-alpha.5" and the ^ doesn't work in alpha,

@menusal menusal self-requested a review April 15, 2024 14:43
menusal
menusal approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@menusal menusal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vmilan
vmilan approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@vmilan vmilan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor comment, and it's pending a fix for the build... And I guess is missing an entry in the changelog. Apart from that LGTM

tsconfig.json
@@ -11,7 +11,7 @@
"allowSyntheticDefaultImports": true,
"noEmit": true,
"baseUrl": ".",
"compileOnSave": true,
// "compileOnSave": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to typescript validor compileOnSave is not a valid option.

Added the entry in the changelog, thx!

@padawannn
Copy link
Contributor Author

@padawannn, can you review all workspace dependencies?

I see "@carto/react-api": "^3.0.0-alpha.3", when the last version is "@carto/react-api": "^3.0.0-alpha.5" and the ^ doesn't work in alpha,

Done, thx

@padawannn padawannn merged commit 33deb45 into master Apr 16, 2024
2 checks passed
@padawannn padawannn deleted the padawannn/deck-v9 branch April 16, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaranadev aaranadev aaranadev approved these changes

@menusal menusal menusal approved these changes

@vmilan vmilan vmilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@padawannn @aaranadev @vmilan @menusal