Keyboard accessibility improvements in Widgets and DS components #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #381221: Enhance information regarding content on Hover and Focus. |
Pull Request Test Coverage Report for Build 7884892885Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit f73ca81): https://cartodb-fb-storybook-react-dev--pr835-feature-accessib-pdehv47f.web.app (expires Tue, 20 Feb 2024 10:18:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
mdeividas
approved these changes
Feb 12, 2024
| @@ -79,6 +79,10 @@ const locales = { | |||
| clear: 'Limpiar', | |||
| selectedItems: '{items, plural, one {# seleccionado} other {# seleccionados}}', | |||
| allSelected: 'Todos seleccionados' | |||
| }, | |||
| chartLegend: { | |||
| next: 'Página siguente', | |||
There was a problem hiding this comment.
typo
Suggested change
| next: 'Página siguente', | |
| next: 'Página siguiente', |
| @@ -19,6 +19,9 @@ export const navigationOverrides = { | |||
| '&:focus-visible': { | |||
| // Solves a known Mui issue: https://github.com/mui/material-ui/issues/23747 | |||
| backgroundColor: 'transparent', | |||
| outline: `none !important`, | |||
| boxShadow: ` inset 0 0 0 2px ${theme.palette.primary.main} !important`, | |||
There was a problem hiding this comment.
Why an empty space at the beginning? Is it required?
VictorVelarde
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/381221/enhance-information-regarding-content-on-hover-and-focus
[sc-381221]