Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-redux] Export 'Filter' types #829

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

donmccurdy
Copy link
Member

Description

Shortcut: https://app.shortcut.com/cartoteam/story/377718/widgets-values-for-filtering
[sc-377718]

Exports Filter types, to be used in Builder.

Type of change

  • Feature

Acceptance

n/a

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@donmccurdy donmccurdy added enhancement New feature or request builder labels Jan 26, 2024
Copy link

This pull request has been linked to Shortcut Story #377718: Widgets values for filtering.

Copy link

github-actions bot commented Jan 26, 2024

Pull Request Test Coverage Report for Build 7669507413

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.226%

Totals Coverage Status
Change from base Build 7655004471: 0.0%
Covered Lines: 2613
Relevant Lines: 3450

💛 - Coveralls

Copy link

github-actions bot commented Jan 26, 2024

Visit the preview URL for this PR (updated for commit 4375c30):

https://cartodb-fb-storybook-react-dev--pr829-donmccurdy-types-jhd1u7ny.web.app

(expires Fri, 02 Feb 2024 14:48:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@donmccurdy donmccurdy changed the title Types: Export 'Filter' types [react-redux] Export 'Filter' types Jan 26, 2024
@donmccurdy donmccurdy requested a review from a team January 29, 2024 14:22
@padawannn padawannn merged commit 1d81a93 into master Jan 30, 2024
2 checks passed
@padawannn padawannn deleted the donmccurdy/types-filter branch January 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants