Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabelWithIndicator component: UI improvements #819

Merged
merged 47 commits into from
Jan 4, 2024

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Jan 4, 2024

Copy link

This pull request has been linked to Shortcut Story #352079: CN - Replace old code with LabelWithIndicator component.

@vmilan vmilan changed the title UploadField component: UI improvements LabelWithIndicator component: UI improvements Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

Pull Request Test Coverage Report for Build 7410080195

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.205%

Totals Coverage Status
Change from base Build 7410018006: 0.0%
Covered Lines: 2609
Relevant Lines: 3446

💛 - Coveralls

@vmilan vmilan requested a review from a team January 4, 2024 13:25
Copy link

github-actions bot commented Jan 4, 2024

Visit the preview URL for this PR (updated for commit 3c1bac6):

https://cartodb-fb-storybook-react-dev--pr819-feature-label-wi-kpa600mo.web.app

(expires Thu, 11 Jan 2024 13:27:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

Copy link
Contributor

@zbigg zbigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vmilan vmilan merged commit b0ee755 into master Jan 4, 2024
2 checks passed
@vmilan vmilan deleted the feature/label-with-indicator-improvements branch January 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants