Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataSources store type #807

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

padawannn
Copy link
Contributor

Description

In the redux package, the dataSources type was dataSources: { [key: string]: string } that obviously is wrong and must be dataSources: { [key: string]: Source },

Type of change

  • Fix

@padawannn padawannn added the bug Something isn't working label Nov 28, 2023
Copy link

github-actions bot commented Nov 28, 2023

Pull Request Test Coverage Report for Build 7018692298

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.169%

Totals Coverage Status
Change from base Build 7010881773: 0.0%
Covered Lines: 2588
Relevant Lines: 3419

💛 - Coveralls

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Nov 28, 2023

Visit the preview URL for this PR (updated for commit 5cba276):

https://cartodb-fb-storybook-react-dev--pr807-padawannn-fix-so-17ksgl7v.web.app

(expires Tue, 05 Dec 2023 12:29:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@padawannn padawannn merged commit 345892e into master Nov 29, 2023
2 checks passed
@padawannn padawannn deleted the padawannn/fix-source-redux-type branch November 29, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants