Freeze widgets during time-series animation #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7099986055
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 64e5685): https://cartodb-fb-storybook-react-dev--pr804-padawannn-map-se-6hxgp6fu.web.app (expires Tue, 12 Dec 2023 11:25:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
…n/map-server-side-filtering-time-series
VictorVelarde
approved these changes
Nov 28, 2023
zbigg
approved these changes
Dec 5, 2023
| @@ -18,6 +18,7 @@ type FilterBasic = { | |||
| values: FilterValues; | |||
| owner?: string; | |||
| params?: Record<string, unknown>; | |||
| ignore?: boolean; | |||
There was a problem hiding this comment.
this flag has very specific use case, maybe more verbose name would be better like ignoreByNonOwners or onlyApplyToOwner or noCrossWidgetFiltering ?
ignore seems too broad and misleading (it's still taken into account, but only by owner widget)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/362678/timeseries-adaptation
Type of change