Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix array columns not working properly in TableWidget #802

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Hotfix array columns not working properly in TableWidget #802

merged 3 commits into from
Nov 23, 2023

Conversation

Josmorsot
Copy link
Contributor

Description

Shortcut: (link)

image

Type of change

  • Fix

@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #365844: [EQT Partners] CARTO 3 Account Map Breaks on Opening Map.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6969409402

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 68.963%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-widgets/src/models/utils.js 1 2 50.0%
packages/react-ui/src/widgets/TableWidgetUI/TableWidgetUI.js 1 3 33.33%
Totals Coverage Status
Change from base Build 6969397005: -0.06%
Covered Lines: 2538
Relevant Lines: 3362
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 79d500c):

https://cartodb-fb-storybook-react-dev--pr802-bug-sc-365844-eq-xou5rx3o.web.app

(expires Thu, 30 Nov 2023 12:09:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@VictorVelarde VictorVelarde changed the title Hotfix Parse array columns properly Hotfix Parse array columns properly in TableWidget Nov 23, 2023
@VictorVelarde VictorVelarde changed the title Hotfix Parse array columns properly in TableWidget Hotfix array columns not working properly in TableWidget Nov 23, 2023
@VictorVelarde VictorVelarde self-requested a review November 23, 2023 12:06
VictorVelarde
VictorVelarde approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Josmorsot Josmorsot merged commit 2ed88d9 into master Nov 23, 2023
2 checks passed
@Josmorsot Josmorsot deleted the bug/sc-365844/eqt-partners-carto-3-account-map-breaks-on branch November 23, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padawannn padawannn padawannn approved these changes

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Josmorsot @VictorVelarde @padawannn