Allow proper server-side for TableWidget #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #362166: Fix Table widget by allowing server-side > frontend adaptations. |
padawannn
commented
Nov 15, 2023
| @@ -4,4 +4,4 @@ export { getCategories } from './CategoryModel'; | |||
| export { geocodeStreetPoint } from './GeocodingModel'; | |||
| export { getScatter, HARD_LIMIT as SCATTER_PLOT_HARD_LIMIT } from './ScatterPlotModel'; | |||
| export { getTimeSeries } from './TimeSeriesModel'; | |||
| export { getTable, paginateTable, HARD_LIMIT as TABLE_HARD_LIMIT } from './TableModel'; | |||
There was a problem hiding this comment.
@aaranadev @menusal we've removed these exports because are no longer necessary. Please confirm us that PS are not using it
There was a problem hiding this comment.
@padawannn Confirmed for our side. you can remove
Pull Request Test Coverage Report for Build 6929581223
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit 153f05a): https://cartodb-fb-storybook-react-dev--pr798-feature-sc-36216-or5tnffe.web.app (expires Mon, 27 Nov 2023 11:47:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/362166/fix-table-widget-by-allowing-server-side-frontend-adaptations
Depends on https://github.com/CartoDB/cloud-native/pull/14455
Type of change