-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-side map filtering with widgets #797
Conversation
This pull request has been linked to Shortcut Story #358934: Server-side filtering in C4R. |
Pull Request Test Coverage Report for Build 6969273117
💛 - Coveralls |
Visit the preview URL for this PR (updated for commit 41dcb22): https://cartodb-fb-storybook-react-dev--pr797-padawannn-map-se-ve94c3zn.web.app (expires Thu, 30 Nov 2023 11:54:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
@@ -0,0 +1,69 @@ | |||
import { Provider } from "@carto/react-core" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the code has been copied from https://github.com/CartoDB/cloud-native/blob/main/commons/lib/fqn.ts
The idea is to move it to an external module at some point.
@@ -0,0 +1,317 @@ | |||
import { Provider } from '@carto/react-core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the code has been copied from https://github.com/CartoDB/cloud-native/blob/main/commons/lib/fqn.ts
The idea is to move it to an external module at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://app.shortcut.com/cartoteam/story/358934/server-side-filtering-in-c4r
The idea is to have a function that transforms a source (table or query) into a query taking into account the widget filters