Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side map filtering with widgets #797

Merged
merged 7 commits into from
Nov 23, 2023

Conversation

padawannn
Copy link
Contributor

@padawannn padawannn commented Nov 9, 2023

https://app.shortcut.com/cartoteam/story/358934/server-side-filtering-in-c4r

The idea is to have a function that transforms a source (table or query) into a query taking into account the widget filters

@padawannn padawannn requested a review from a team November 9, 2023 09:48
Copy link

This pull request has been linked to Shortcut Story #358934: Server-side filtering in C4R.

Copy link

github-actions bot commented Nov 13, 2023

Pull Request Test Coverage Report for Build 6969273117

  • 61 of 138 (44.2%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 69.025%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-widgets/src/models/utils.js 9 17 52.94%
packages/react-widgets/src/models/fqn.js 51 120 42.5%
Totals Coverage Status
Change from base Build 6929718141: -1.7%
Covered Lines: 2536
Relevant Lines: 3357

💛 - Coveralls

Copy link

github-actions bot commented Nov 13, 2023

Visit the preview URL for this PR (updated for commit 41dcb22):

https://cartodb-fb-storybook-react-dev--pr797-padawannn-map-se-ve94c3zn.web.app

(expires Thu, 30 Nov 2023 11:54:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@@ -0,0 +1,69 @@
import { Provider } from "@carto/react-core"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code has been copied from https://github.com/CartoDB/cloud-native/blob/main/commons/lib/fqn.ts
The idea is to move it to an external module at some point.

@@ -0,0 +1,317 @@
import { Provider } from '@carto/react-core';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code has been copied from https://github.com/CartoDB/cloud-native/blob/main/commons/lib/fqn.ts
The idea is to move it to an external module at some point.

@padawannn padawannn marked this pull request as ready for review November 13, 2023 15:16
@padawannn padawannn added the enhancement New feature or request label Nov 13, 2023
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VictorVelarde VictorVelarde merged commit 5f07195 into master Nov 23, 2023
2 checks passed
@VictorVelarde VictorVelarde deleted the padawannn/map-server-side-filtering branch November 23, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants