-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectField: extend to accept more data structures as children and to fix placeholder #796
Conversation
This pull request has been linked to Shortcut Story #352074: CN - Replace old code with SelectField component. |
Pull Request Test Coverage Report for Build 7396927713
💛 - Coveralls |
Visit the preview URL for this PR (updated for commit 0283cb5): https://cartodb-fb-storybook-react-dev--pr796-feature-extend-s-xfdojm7w.web.app (expires Wed, 10 Jan 2024 12:01:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. Do we have Design check over storybook?
PD. Let's be a bit more verbose about the new 'supported use cases', at least in CHANGELOG
No, since they are going to review in the dedicated, I didn't want to overwhelm them with several reviews of the same thing. Changed changelog and PR title. |
Description
Shortcut: https://app.shortcut.com/cartoteam/story/352074/cn-replace-old-code-with-selectfield-component
[sc-352074]