Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppBar: Add new color keys in the Theme #794

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Oct 23, 2023

Description

Shortcut: https://app.shortcut.com/cartoteam/story/344453/whitelabel-issue-icons-and-other-elements-are-not-respecting-the-app-bar-text-color
[sc-344453]

Add basic support for colors customization in AppBar core components.

Screenshot 2023-10-19 at 11 55 55

@shortcut-integration
Copy link

@vmilan vmilan changed the title AppBar: Add support for custom branding AppBar: Add support for custom branding in the Theme Oct 23, 2023
@vmilan vmilan changed the title AppBar: Add support for custom branding in the Theme AppBar: Add new color keys in the Theme Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Pull Request Test Coverage Report for Build 6616175742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.721%

Totals Coverage Status
Change from base Build 6578563630: 0.0%
Covered Lines: 2483
Relevant Lines: 3226

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Visit the preview URL for this PR (updated for commit 9f48bd0):

https://cartodb-fb-storybook-react-dev--pr794-feature-appbar-b-mw9iql1u.web.app

(expires Mon, 30 Oct 2023 16:39:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@vmilan vmilan requested a review from VictorVelarde October 24, 2023 07:28
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@vmilan vmilan merged commit 6ec7de5 into master Oct 25, 2023
@vmilan vmilan deleted the feature/appbar-branding branch October 25, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants