Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectField: Remove empty space at the beginning #772

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Sep 13, 2023

Description

Shortcut: https://app.shortcut.com/cartoteam/story/343957/qa-ui-export-a-workflow

The empty option was added due to some issues with tab navigation, but is not needed anymore and is causing an unwanted blank space.

Remove the white space at the beginning, that white space looks like something failed to render.

This change also affects MultipleSelectField component.

Current UI
Screenshot 2023-09-13 at 11 21 50

Fix
Screenshot 2023-09-13 at 11 22 11

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Visit the preview URL for this PR (updated for commit afa8e83):

https://cartodb-fb-storybook-react-dev--pr772-feature-selectfi-sks7wtnt.web.app

(expires Wed, 20 Sep 2023 11:03:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@vmilan vmilan changed the title SelectField: Remove empty item at the beginning SelectField: Remove empty space at the beginning Sep 13, 2023
@vmilan vmilan requested review from mdeividas and a team September 13, 2023 10:56
@github-actions
Copy link

Pull Request Test Coverage Report for Build 6171489216

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.503%

Totals Coverage Status
Change from base Build 6159410494: 0.0%
Covered Lines: 2261
Relevant Lines: 2931

💛 - Coveralls

Copy link
Contributor

@mdeividas mdeividas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmilan vmilan merged commit 65a1d40 into master Sep 13, 2023
@vmilan vmilan deleted the feature/selectfield-empty-line branch September 13, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants