Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: widgets loading state when calculating client-side #75

Merged
merged 8 commits into from
Feb 2, 2021
Merged

fix: widgets loading state when calculating client-side #75

merged 8 commits into from
Feb 2, 2021

Conversation

AdriSolid
Copy link
Contributor

Background

Widget loaders were not working in client-side-mode. Widget loaders should be displayed every time viewport changes, ending with the end of the computation.

Change List

  • Add a new store state with the widget ids.
  • Add useLoadingStateFromStore hook and use it in each /widgets component.

@AdriSolid AdriSolid mentioned this pull request Feb 1, 2021
Merged
@VictorVelarde VictorVelarde changed the title fix: widget loaders from client-side mode fix: widgets loading state when calculating client-side Feb 1, 2021
@VictorVelarde
refactor: limit widgetLoading actions to just one widget
27842f9 
Simplifying the internal structure of the reducers, by removing the multiple option
@VictorVelarde
Merge branch 'master' into fix/widgets-loader
80d8c4d
VictorVelarde
VictorVelarde approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@VictorVelarde
Copy link
Contributor

@AdriSolid I made some refactors here:

  • 'loaders' to 'loading' (everywhere)
  • actions modification: setWidgetLoadingState / removeWidgetLoadingState (notice the singular) + a new setAllWidgetsLoadingState

Please have a look at the changes, test them to see if I broke anything and, if you are ok with it, go ahead and merge it

@AdriSolid
Copy link
Contributor Author

@VictorVelarde nice! Will need to check in a near-future if can pass to removeWidgetLoadingState a widgetIds list.

@AdriSolid AdriSolid merged commit e760e36 into master Feb 2, 2021
@VictorVelarde VictorVelarde deleted the fix/widgets-loader branch February 2, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdriSolid @VictorVelarde