Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add click event to GoogleMap component #747

Conversation

Shylpx
Copy link
Contributor

@Shylpx Shylpx commented Jul 21, 2023

Description

Shortcut

Propagate onClick event to GoogleMap component (already included for DeckGLComponent, but not available yet for Google basemaps).

Type of change

  • Feature

Acceptance

  • Add onClick property to GoogleMap component:

Screenshot from 2023-07-21 12-00-31

click-event

@shortcut-integration
Copy link

@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Pull Request Test Coverage Report for Build 5644329277

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.628%

Totals Coverage Status
Change from base Build 5623151663: 0.0%
Covered Lines: 2261
Relevant Lines: 2925

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Visit the preview URL for this PR (updated for commit a7f3cc5):

https://cartodb-fb-storybook-react-dev--pr747-feature-sc-33367-jvnixj5z.web.app

(expires Mon, 31 Jul 2023 11:43:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #33367: Mapa de orígenes.

@Shylpx Shylpx marked this pull request as ready for review July 21, 2023 11:33
@Shylpx Shylpx requested a review from a team July 24, 2023 11:33
@VictorVelarde VictorVelarde merged commit 40fa0a5 into master Jul 25, 2023
@VictorVelarde VictorVelarde deleted the feature/sc-333679/decathlon-add-click-event-to-google-maps branch July 25, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants