Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectField Storybook leftovers #746

Merged
merged 2 commits into from
Jul 21, 2023
Merged

SelectField Storybook leftovers #746

merged 2 commits into from
Jul 21, 2023

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Jul 20, 2023

Description

Cleanup related with latest changes in SelectField stories in Storybook.

@vmilan vmilan changed the title SelectField stories leftovers SelectField Storybook leftovers Jul 20, 2023
@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5614284540

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.628%
Totals Coverage Status
Change from base Build 5601842566: 0.0%
Covered Lines: 2261
Relevant Lines: 2925
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0a7311d):

https://cartodb-fb-storybook-react-dev--pr746-feature-fix-tabl-u3fymxcr.web.app

(expires Thu, 27 Jul 2023 18:01:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@vmilan vmilan requested a review from a team July 21, 2023 07:21
@vmilan vmilan merged commit accd76f into master Jul 21, 2023
@vmilan vmilan deleted the feature/fix-table-stories branch July 21, 2023 07:36
mdeividas
mdeividas approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@mdeividas mdeividas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeividas mdeividas mdeividas approved these changes

@Josmorsot Josmorsot Josmorsot approved these changes

Assignees
No one assigned
Labels
design system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmilan @Josmorsot @mdeividas