Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactWidgets - Search by coordinates support #731

Merged
merged 4 commits into from
Jul 5, 2023
Merged

ReactWidgets - Search by coordinates support #731

merged 4 commits into from
Jul 5, 2023

Conversation

eamador
Copy link
Contributor

@eamador eamador commented Jul 5, 2023 •
edited
Loading

ReactWidgets - Search by coordinates support

Shortcut: https://app.shortcut.com/cartoteam/story/327512/implement-search-coordinates

useGeocoderControllerWidget supports search by coordinates.

Captura de Pantalla 2023-07-04 a las 13 48 50

Captura de Pantalla 2023-07-05 a las 9 39 14

Type of change

  • Feature
  • Tests

Acceptance

  1. go to X
  2. test Y
  3. assert Z

If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@eamador eamador added the enhancement New feature or request label Jul 5, 2023
@eamador eamador requested a review from VictorVelarde July 5, 2023 07:32
@github-actions
Copy link

github-actions bot commented Jul 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5462788918

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 71.634%
Totals Coverage Status
Change from base Build 5461140495: 0.2%
Covered Lines: 2256
Relevant Lines: 2920
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jul 5, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit db541c7):

https://cartodb-fb-storybook-react-dev--pr731-feature-search-b-3qnsw8ow.web.app

(expires Wed, 12 Jul 2023 09:49:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

Josmorsot
Josmorsot approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@Josmorsot Josmorsot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you have to add the changelog

@eamador eamador merged commit f59d85e into master Jul 5, 2023
@VictorVelarde VictorVelarde deleted the feature/search-by-coordinates branch July 5, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josmorsot Josmorsot Josmorsot approved these changes

@VictorVelarde VictorVelarde Awaiting requested review from VictorVelarde

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eamador @Josmorsot