Fix histogram zr handler #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #322439: Histogram widget crashes. |
453a424 to
8cf4f3b
Compare
VictorVelarde
commented
Jun 14, 2023
| @@ -242,7 +242,7 @@ export default function useTimeSeriesInteractivity({ echartsInstance, data }) { | |||
|
|
|||
| // Aux | |||
| function addEventWithCleanUp(zr, eventKey, event) { | |||
| if (zr) { | |||
| if (zr && zr.handler) { | |||
VictorVelarde
commented
Jun 14, 2023
| @@ -114,7 +114,7 @@ export default function useHistogramInteractivity({ | |||
|
|
|||
| // Aux | |||
| function addEventWithCleanUp(zr, eventKey, event) { | |||
| if (zr) { | |||
| if (zr && zr.handler) { | |||
There was a problem hiding this comment.
Key part here
Pull Request Test Coverage Report for Build 5270475680
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: 322439
[sc-322439]
HistogramWidget fix, broken after adding skeleton (missing ref in object when dealing with echart events, through ZRender lib)
Type of change
Acceptance
HistogramWidget doesn't break. You can move around the map and it correctly manages skeleton on-off
Basic checklist