FormulaWidget: implement new custom operation mechanism #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #320253: Implement new custom operation mechanism in FormulaWidget in C4R. |
Pull Request Test Coverage Report for Build 5389020875
💛 - Coveralls |
bab0af3 to
23c9607
Compare
|
Visit the preview URL for this PR (updated for commit 96edcda): https://cartodb-fb-storybook-react-dev--pr699-feature-sc-32025-nu2uo8ng.web.app (expires Tue, 04 Jul 2023 11:15:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
CHANGELOG.md
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## Not released | |||
|
|
|||
| - Formula widget supports custom aggregation expression [699](https://github.com/CartoDB/carto-react/pull/699) | |||
| - Fix executeModel get url calculation [699](https://github.com/CartoDB/carto-react/pull/699) | |||
There was a problem hiding this comment.
fix... affecting what part of widgets? all?
There was a problem hiding this comment.
yes, it's for all remote-mode & global widgets
| @@ -95,15 +103,17 @@ export default function useWidgetFetch( | |||
| spatialFilter: geometryToIntersect | |||
| }) | |||
| .then((data) => { | |||
| onStateChange?.({ state: WidgetStateType.Success, data }); | |||
e9f8f90 to
f876afa
Compare
f876afa to
e76ac3d
Compare
…sc-320253/implement-new-custom-operation-mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/320253/implement-new-custom-operation-mechanism-in-formulawidget-in-c4r
FormulaWidget support for
'custom'aggregation expression passed asoperationExpand newonStateChangecallbackInternal: useWidgetFetch support for
onStateChangecallbackType of change
Acceptance
N/A
Basic checklist